Remove rancher-kubeconfigs feature #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Danil-Grigorev please close the related issue rancher/turtles-docs#112 as |
Danil-Grigorev
force-pushed
the
remove-rancher-kubeconfig-label
branch
from
70497bb to
6822bc8
Compare
furkatgofurov7
previously approved these changes
Jan 22, 2025
Danil-Grigorev
force-pushed
the
remove-rancher-kubeconfig-label
branch
from
6822bc8 to
703c44f
Compare
anmazzotti
previously approved these changes
Jan 23, 2025
Danil-Grigorev
force-pushed
the
remove-rancher-kubeconfig-label
branch
3 times, most recently
from
77720bb to
313be12
Compare
Current rancher version used with turtles uses CAPI 1.9, so the feature is no longer needed and thus removed. Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
remove-rancher-kubeconfig-label
branch
from
313be12 to
0fd81f6
Compare
salasberryfin
approved these changes
Jan 23, 2025
alexander-demicev
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Current rancher version used with turtles uses CAPI 1.9, so the feature is no longer needed and thus removed. It was disabled by default for a while.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1031
Special notes for your reviewer:
Checklist: