Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back vsphere tests #1034

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

vSphere tests were delete with v1 suite, this PR brings them back

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Alexandr Demicev <[email protected]>
Signed-off-by: Alexandr Demicev <[email protected]>
@alexander-demicev alexander-demicev requested a review from a team as a code owner January 22, 2025 12:10
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for context, instead of an issue: #1024 (comment)

This is also needed changes in suite-test.go:


if Label(e2e.LocalTestLabel).MatchesLabelFilter(GinkgoLabelFilter()) {
			By("Running local vSphere tests, deploying vSphere infrastructure provider")

			testenv.CAPIOperatorDeployProvider(ctx, testenv.CAPIOperatorDeployProviderInput{
				BootstrapClusterProxy: setupClusterResult.BootstrapClusterProxy,
				CAPIProvidersSecretsYAML: [][]byte{
					e2e.VSphereProviderSecret,
				},
				CAPIProvidersYAML: e2e.CapvProvider,
				WaitForDeployments: []testenv.NamespaceName{
					{
						Name:      "capv-controller-manager",
						Namespace: "capv-system",
					},
				},
			})
		}

@alexander-demicev
Copy link
Member Author

@Danil-Grigorev it's already present there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants