fix: remove v1 clusters for migration in post-upgrade job #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
added
kind/bug
furkatgofurov7
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Now that there's a single method for importing clusters via
clusters.management.cattle.io(v3) and migration is automatically applied for allclusters.provisioning.cattle.io(v1) we no longer have values in the Helm chart that control when Rancher clusters deletion is applied (this is where the changes are introduced).In this case, as reported by @cpinjani here, CAPI clusters are being un-imported after upgrade because the post-upgrade job deletes all v3 cluster resources and then the controller labels the CAPI cluster
imported=true. For this to apply only for migration scenarios we should delete v1 clusters only (and eventually remove this action completely?).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist: