Add classes to BMSBK #263
Open
Add classes to BMSBK #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
+ Coverage 77.62% 77.79% +0.16%
==========================================
Files 79 79
Lines 4027 4057 +30
==========================================
+ Hits 3126 3156 +30
Misses 901 901 ☔ View full report in Codecov by Sentry. |
duncathan
requested changes
Jan 13, 2025
duncathan
requested changes
Jan 14, 2025
| construct.Terminated, | ||
| ) # fmt: skip | ||
|
|
||
|
|
||
| class BlockType(Enum): | ||
| class BlockType(StrEnum): |
There was a problem hiding this comment.
StrEnum breaks python 3.10 - do class BlockType(str, Enum) instead
| original_type = block_group.block_type | ||
| assert original_type == BlockType.POWER_BOMB | ||
| block_group.block_type = BlockType.BOMB | ||
| assert original_type != BlockType.BOMB |
There was a problem hiding this comment.
block_group = surface_bmsbk.get_block_group(0)
assert block_group.block_type is BlockType.POWER_BOMB
block_group.block_type = BlockType.BOMB
assert block_group.block_type is BlockType.BOMB| original_time = block.respawn_time | ||
| assert original_time == 0.0 | ||
| block.respawn_time = 5.0 | ||
| assert original_time != block.respawn_time |
There was a problem hiding this comment.
block = surface_bmsbk.get_block_group(0).get_block(0)
assert block.respawn_time == 0.0
block.respawn_time = 5.0
assert block.respawn_time == 5.0| assert block.model_name != "sg_casca80" | ||
|
|
||
| block.vignette_name = "sg_real_vignette" | ||
| assert block.vignette_name != "" |
There was a problem hiding this comment.
block = surface_bmsbk.get_block_group(0).get_block(0)
assert block.model_name == "sd_casca80"
block.model_name = "sg_real_model"
assert block.model_name == "sg_real_model"
assert block.vignette_name == ""
block.vignette_name = "sg_real_vignette"
assert block.vignette_name == "sg_real_vignette"| original_position = block.position | ||
| assert original_position == [-23100.0, 10700.0, 0.0] | ||
| block.position = [100.0, 200.0, 0.0] | ||
| assert original_position != block.position |
There was a problem hiding this comment.
block = surface_bmsbk.get_block_group(0).get_block(0)
assert block.position == [-23100.0, 10700.0, 0.0]
block.position = Vec3(100.0, 200.0, 0.0)
assert block.position == [100.0, 200.0, 0.0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now has classes with properties to better handle modifying
block_groups