Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classes to BMSMSD #265

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Add classes to BMSMSD #265

merged 7 commits into from
Jan 17, 2025

Conversation

dyceron
Copy link
Contributor

@dyceron dyceron commented Jan 11, 2025

Adds new classes to change tiles and icons

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 94.49541% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.04%. Comparing base (b0de65a) to head (612ef65).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...c/mercury_engine_data_structures/formats/bmsmsd.py 93.87% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   77.62%   78.04%   +0.41%     
==========================================
  Files          79       80       +1     
  Lines        4027     4131     +104     
==========================================
+ Hits         3126     3224      +98     
- Misses        901      907       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyceron dyceron marked this pull request as draft January 12, 2025 00:31
@dyceron dyceron marked this pull request as ready for review January 12, 2025 01:00
src/mercury_engine_data_structures/formats/bmsmsd.py Outdated Show resolved Hide resolved
src/mercury_engine_data_structures/formats/bmsmsd.py Outdated Show resolved Hide resolved
src/mercury_engine_data_structures/formats/bmsmsd.py Outdated Show resolved Hide resolved
src/mercury_engine_data_structures/formats/bmsmsd.py Outdated Show resolved Hide resolved
src/mercury_engine_data_structures/formats/bmsmsd.py Outdated Show resolved Hide resolved
src/mercury_engine_data_structures/formats/bmsmsd.py Outdated Show resolved Hide resolved
src/mercury_engine_data_structures/formats/bmsmsd.py Outdated Show resolved Hide resolved
src/mercury_engine_data_structures/formats/bmsmsd.py Outdated Show resolved Hide resolved
@dyceron
Copy link
Contributor Author

dyceron commented Jan 16, 2025

  • Added a new adapter for FlagsEnum
  • Added a new common type

@dyceron dyceron requested a review from duncathan January 16, 2025 23:39
@dyceron dyceron requested a review from duncathan January 16, 2025 23:59
@dyceron dyceron added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 0627881 Jan 17, 2025
11 checks passed
@dyceron dyceron deleted the bmsmsd branch January 17, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants