-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widescreen HUD Hack Patch for Echoes #108
base: main
Are you sure you want to change the base?
Conversation
intentional comet
Description
Description
Description
Makes it so RDV can just call it directly instead of relying on a config file
for more information, see https://pre-commit.ci
…-prime-rando into WidescreenHUDPatch
Restore vanilla behavior when widescreen hack is disabled Needed until RDV is updated to no longer cache patched DOL files
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 87.42% 86.72% -0.71%
==========================================
Files 41 43 +2
Lines 1782 1830 +48
==========================================
+ Hits 1558 1587 +29
- Misses 224 243 +19 ☔ View full report in Codecov by Sentry. |
I think, at this stage, it's ready to go as is Future plans do involve stubbing out DrawWidescreen:
So, it's ready for initial testing as right now |
Fixed comment typo
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Setting this as a draft again - reworking a lot of the dol patches and there might be things incomplete |
Should be good to go now, opening for review |
fca8b75
to
bda18b6
Compare
Leaving this as a draft for now because this will depend on other PRs for other repositories and there's likely a lot to be tested and change
What this does:
For DOL patches, new entry in EchoesDolPatchesData
To-Do
Open PR for the other repos