-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern packaging + ruff + numpy 2 compat #187
Conversation
Sweet! Thanks @raphaelvallat, I was planning to include this in next release as well. I'll check it on my end in the next hour with a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raphaelvallat sorry I know this is still WIP and you didn't request this, but I just glossed it over and here are small/quick things to add. All comments are trivially addressable and probably would've come up anyways during your checks so I hope they speed things up for you.
As far as Ruff formatting goes I think it will only end up changing 3 files when you run it. Currently the workflow breaks but it should pass once you run the formatter.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 83.93% 77.24% -6.69%
==========================================
Files 24 13 -11
Lines 3536 2659 -877
Branches 0 324 +324
==========================================
- Hits 2968 2054 -914
Misses 568 568
- Partials 0 37 +37 ☔ View full report in Codecov by Sentry. |
Note that there's a CI failure on Python 3.12 because of a depreceated import of |
Ready for review @remrama ! There's one CI failure because of coverage that I think we can ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @raphaelvallat! Thanks a lot for doing this, I think it makes it easier to work on subsequent PRs.
PR ready to be merged as soon as #127 is merged! |
* Including manual conflict resolution on [test_]staging.py
This PR implements the following changes:
pyproject.toml
. Source files are moved to thesrc/yasa/
folder, while tests are now in thetests
folder at the root directory