remove ucx from wheel images #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
breaking
pentschev
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
There are several build issues that look unrelated, perhaps rate-limit issues:
2 warnings found (use --debug to expand):
- FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 7)
- FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 9)
ERROR: toomanyrequests: Too Many Requests (HAP429).
Other than that LGTM, thanks @jameslamb !
|
I just triggered a re-run of the failing jobs, I strongly suspect that'll fix it. |
Indeed it fixed. Thanks James! |
vyasr
approved these changes
Jun 28, 2024
This was referenced Jul 1, 2024
rapids-bot bot
pushed a commit
to rapidsai/ucx-py
that referenced
this pull request
Jul 1, 2024
For rapidsai/build-planning#57, #1041 switched `ucx-py` over to `libucx` wheels. To test that that was working, it added some code to building scripts to remove system installations of UCX libraries. That should no longer be necessary as of rapidsai/ci-imgs#154. This proposes removing that code for managing system dependencies of UCX libraries, to simplify those build scripts a bit. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Peter Andreas Entschev (https://github.com/pentschev) URL: #1053
rapids-bot bot
pushed a commit
to rapidsai/ucxx
that referenced
this pull request
Jul 2, 2024
For rapidsai/build-planning#57, #226 switched `ucxx` over to `libucx` wheels. To test that that was working, it added some code to building scripts to remove system installations of UCX libraries. That should no longer be necessary as of rapidsai/ci-imgs#154. This proposes removing that code for managing system dependencies of UCX libraries, to simplify those build scripts a bit. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Mike Sarahan (https://github.com/msarahan) URL: #241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of rapidsai/build-planning#57, it should no longer be necessary to install openucx in the wheel images here.
Projects depending on UCX in their CI all now get it from either the
ucxconda-forge package or thelibucxwheels published from https://github.com/rapidsai/ucx-wheels.ref: #145 (comment)
This proposes removing UCX builds in the wheel images. Benefits of that:
ucx-pyanducxx(e.g. Use UCX wheels ucxx#226 (comment))