Skip to content

Commit

Permalink
Remove unnecessary stream sync for h_initial_str_offsets
Browse files Browse the repository at this point in the history
  • Loading branch information
mhaseeb123 committed Jan 22, 2025
1 parent e838e72 commit 1a34807
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cpp/src/io/parquet/reader_impl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -415,13 +415,13 @@ void reader::impl::decode_page_data(read_mode mode, size_t skip_rows, size_t num
// synchronize the streams
cudf::detail::join_streams(streams, _stream);

// Sync stream here to use the offsets below
auto h_initial_str_offsets = cudf::detail::make_host_vector_sync(initial_str_offsets, _stream);

subpass.pages.device_to_host_async(_stream);
page_nesting.device_to_host_async(_stream);
page_nesting_decode.device_to_host_async(_stream);

// Copy over initial string offsets from device
auto h_initial_str_offsets = cudf::detail::make_host_vector_async(initial_str_offsets, _stream);

if (auto const error = error_code.value_sync(_stream); error != 0) {
CUDF_FAIL("Parquet data decode failed with code(s) " + kernel_error::to_string(error));
}
Expand Down

0 comments on commit 1a34807

Please sign in to comment.