Skip to content

Commit

Permalink
Disable boolean types in bloom filters.
Browse files Browse the repository at this point in the history
  • Loading branch information
mhaseeb123 committed Jan 13, 2025
1 parent 86f0c12 commit bd9aa04
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions cpp/src/io/parquet/bloom_filter_reader.cu
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,10 @@ struct bloom_filter_caster {
using policy_type = cuco::arrow_filter_policy<key_type, cudf::hashing::detail::XXHash_64>;
using word_type = typename policy_type::word_type;

// List, Struct, Dictionary types are not supported
if constexpr (cudf::is_compound<T>() and not std::is_same_v<T, string_view>) {
CUDF_FAIL("Compound types don't support equality predicate");
// Boolean, List, Struct, Dictionary types are not supported
if constexpr (std::is_same_v<T, bool> or
(cudf::is_compound<T>() and not std::is_same_v<T, string_view>)) {
CUDF_FAIL("Bloom filters do not support boolean or compound types");
} else {
// Check if the literal has the same type as the predicate column
CUDF_EXPECTS(
Expand Down

0 comments on commit bd9aa04

Please sign in to comment.