-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify a version for rapids_logger dependency #17573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyasr Can you take a quick look? I am approving but I think your input would be helpful.
I've just updated the commit hash to reflect the last PR in |
Wow Nghia was quick I just came here to make the same change that he did 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks fine to me for now. It's not the cleanest but we will have things in a cleaner state before the 25.02 release so I'm fine with patching in the version this way until then to ease the transition.
Nghia found another minor issue with rapids-logger that I'm going to resolve now so that we can bump again in this PR. |
@ttnghia I pushed a fix to rapidsai/rapids-logger#3. Could you rebase your local changes onto Jason's cudf branch's latest commit and make sure that things build as you expect (you can link to |
CI is passing here. Once @ttnghia can confirm that the latest version fixes his issue we can merge the rapids-logger PR, update the commit hash in this PR (and revert the repo changes) then rerun and merge. |
I confirm that the patch fixes all the previous bugs. |
This fix appears to be necessary for devcontainers, too. I am getting
but it builds successfully with this PR. |
What happens here next? Is this dependent on merging rapidsai/rapids-logger#3 ? |
Yes, I merged that fix and updated the commit hash here. If we get through a few CI builds, I think this will be good enough to admin-merge so we are unblocked. |
Description
#17307 broke builds that use the rapids-cmake pinned dependencies feature since no version was specified for the rapids_logger dependency. This adds a version string equal to the git tag so the dependency has a stated version.
Checklist