Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parquet reader long row test #17735

Open
wants to merge 6 commits into
base: branch-25.02
Choose a base branch
from
Open

Add parquet reader long row test #17735

wants to merge 6 commits into from

Conversation

pmattione-nvidia
Copy link
Contributor

@pmattione-nvidia pmattione-nvidia commented Jan 14, 2025 •
edited
Loading

Adds a python test that makes sure that the parquet reader can correctly handle a list row that spans more than one page. This test resolves this issue, which was created to catch problems that can happen like the bug fixed here. This test passes now, but fails if the given fix is not present.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pmattione-nvidia pmattione-nvidia added tests Unit testing for project improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 14, 2025
@pmattione-nvidia pmattione-nvidia self-assigned this Jan 14, 2025
@pmattione-nvidia pmattione-nvidia requested a review from a team as a code owner January 14, 2025 17:54
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 14, 2025
@pmattione-nvidia pmattione-nvidia mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec

At least 1 approving review is required to merge this pull request.

Assignees

@pmattione-nvidia pmattione-nvidia

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API. tests Unit testing for project
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add testing for reading parquet files with lists spanning multiple pages.
1 participant
@pmattione-nvidia