cugraph: declare pylibraft dependency for wheels #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
msarahan
approved these changes
Jan 14, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4854
cugraph-cu{11,12}has a hard runtime dependency onpylibraft:cugraph/python/cugraph/cugraph/dask/comms/comms.py
Line 29 in dd228f9
But doesn't declare that dependency for wheels.
This PR explicitly declares it.
Notes for Reviewers
This only affects wheels... this dependency is correctly declared in the
cugraphconda packages.cugraph/conda/recipes/cugraph/meta.yaml
Line 90 in dd228f9
How was this not caught in CI?
Other dependencies of
cugraphpull it in.