Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with CUDA 12.8.0 #4896

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 28, 2025

This PR uses CUDA 12.8.0 to build and test.

xref: rapidsai/build-planning#139

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 28, 2025
Copy link

copy-pr-bot bot commented Jan 28, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the conda label Jan 28, 2025
@bdice bdice added the DO NOT MERGE Hold off on merging; see PR for details label Jan 28, 2025
@bdice bdice marked this pull request as ready for review January 28, 2025 16:02
@bdice bdice requested review from a team as code owners January 28, 2025 16:02
@bdice bdice requested a review from jameslamb January 28, 2025 16:02
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are more code changes required here.

Error: calling a __host__ function from a __host__ __device__ function is not allowed
          detected during:
            instantiation of "cuda::std::__4::__optional_destruct_base<_Tp, true>::__optional_destruct_base(cuda::std::__4::in_place_t, _Args &&...) [with _Tp=cugraph::detail::edge_partition_edge_property_device_view_t<int32_t, const uint32_t *, __nv_bool>, _Args=<cugraph::edge_property_view_t<int32_t, const uint32_t *, __nv_bool> &, int>]" at line 705 of $SRC_DIR/cpp/build/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include/cuda/std/detail/libcxx/include/optional
            implicit generation of "cuda::std::__4::__optional_storage_base<cuda::std::__4::decay<cugraph::detail::edge_partition_edge_property_device_view_t<cugraph::graph_view_t<int32_t, int32_t, false, false, void>::edge_type, const uint32_t *, __nv_bool>>::type>::__optional_storage_base(cuda::std::__4::in_place_t, _Args &&...) [with _Args=<cugraph::edge_property_view_t<int32_t, const uint32_t *, __nv_bool> &, int>]" at line 705 of $SRC_DIR/cpp/build/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include/cuda/std/detail/libcxx/include/optional
            instantiation of class "cuda::std::__4::__optional_storage_base<_Tp> [with _Tp=cugraph::detail::edge_partition_edge_property_device_view_t<int32_t, const uint32_t *, __nv_bool>]" at line 705 of $SRC_DIR/cpp/build/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include/cuda/std/detail/libcxx/include/optional
            implicit generation of "cuda::std::__4::__optional_copy_base<cuda::std::__4::decay<cugraph::detail::edge_partition_edge_property_device_view_t<cugraph::graph_view_t<int32_t, int32_t, false, false, void>::edge_type, const uint32_t *, __nv_bool>>::type, cuda::std::__4::__smf_availability::__trivial>::__optional_copy_base(cuda::std::__4::in_place_t, _Args &&...) [with _Args=<cugraph::edge_property_view_t<int32_t, const uint32_t *, __nv_bool> &, int>]" at line 705 of $SRC_DIR/cpp/build/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include/cuda/std/detail/libcxx/include/optional
            instantiation of class "cuda::std::__4::__optional_copy_base<_Tp, <unnamed>> [with _Tp=cugraph::detail::edge_partition_edge_property_device_view_t<int32_t, const uint32_t *, __nv_bool>, <unnamed>=cuda::std::__4::__smf_availability::__trivial]" at line 705 of $SRC_DIR/cpp/build/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include/cuda/std/detail/libcxx/include/optional
            [ 7 instantiation contexts not shown ]

(conda build link (CUDA 12.8))

I see similar stuff in CUDA 12.8 wheel builds.

@bdice
Copy link
Contributor Author

bdice commented Jan 29, 2025

I'm pretty sure builds were expected to work here. This could be a new-ish conflict from #4891 interacting poorly with CUDA 12.8. @miscco Do you have any thoughts on this?

@miscco
Copy link
Contributor

miscco commented Jan 29, 2025

Oh screw it, it seems we are missing the execution check suppression on the bae class constructors

@jakirkham
Copy link
Member

Think this is fixed with Rob's PR: rapidsai/rapids-cmake#756

This backports Michael's CCCL PR: NVIDIA/cccl#3578

@bdice
Copy link
Contributor Author

bdice commented Jan 30, 2025

Wheel builds are only like ~10-13% done after 4 hours. This seems unusual, even with the new compiler and new CCCL version causing zero sccache hits.

@bdice bdice removed the DO NOT MERGE Hold off on merging; see PR for details label Jan 30, 2025
@jameslamb jameslamb self-requested a review January 30, 2025 20:14
@vyasr
Copy link
Contributor

vyasr commented Jan 31, 2025

/merge

@jakirkham
Copy link
Member

One CI job failed due to some SSL error

FAILED tests/utils/test_dataset.py::test_benchmarking_datasets[dataset3] - ssl.SSLError: [SYS] unknown error (_ssl.c:2578)

Restarting CI

@rapids-bot rapids-bot bot merged commit 1d542ef into rapidsai:branch-25.02 Jan 31, 2025
79 checks passed
@jakirkham
Copy link
Member

Huzzah! 🥳

Thanks all 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants