Fix building cuml with CCCL main #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
5 - DO NOT MERGE
KyleFromNVIDIA
approved these changes
May 9, 2024
trxcllnt
added
3 - Ready for Review
trxcllnt
commented
May 13, 2024
trxcllnt
commented
May 14, 2024
7 tasks
|
Looks like the changes in this PR are working and the failing tests are due to missing RAFT symbols. |
dantegd
approved these changes
May 28, 2024
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/rapids-cmake
that referenced
this pull request
Jun 7, 2024
Updates CCCL to v2.5.0 and a more recent cuCollections commit. Using cuco at [6923b3](NVIDIA/cuCollections@6923b3b) because it was before NVIDIA/cuCollections#479, which is a breaking change for libcudf. CCCL PR: * NVIDIA/cccl#1667 RAPIDS PRs: * rapidsai/cudf#15552 * rapidsai/cuml#5886 * rapidsai/cugraph#4404 * rapidsai/cuspatial#1382 Authors: - Paul Taylor (https://github.com/trxcllnt) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) URL: #607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to rapidsai/cudf#15552, we are testing building RAPIDS with CCCL's main branch to get ahead of any breaking changes.