Add ability to pull a wheel artifact as well as a conda one

[vyasr]

This generalizes the preexisting rapids-get-pr-conda-artifact to support wheels via rapids-get-pr-artifact. The former is now a trivial passthrough to the latter for backwards compatibility.

[jameslamb]

Have you seen that there's already a rapids-get-pr-wheel-artifact that does this? Would that meet the need for whatever you're trying to do?

https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-get-pr-wheel-artifact

I've found it helpful for testing PRs that rely on wheels from other PRs / repos.

[vyasr]

Wow. Well... no 😢 my local copy of gha-tools must have been very out of date, and I haven't done nearly as much wheel development of late. Ah well. I guess the question now is whether it's worth using this PR as an opportunity for cleanup to make rapids-get-pr-conda-artifact and rapids-get-pr-wheel-artifact both call the new function. The two scripts are basically copies of each other and now that I've already made this PR it seems like we might as well do to the work to unify them. WDYT? If you'd rather skip that idea I can close this PR.

[jameslamb]

I'm supportive of consolidating more of the shared logic into one place like this, if you want to spend the time on it! Happy to review and help test.

If rapids-get-pr-artifact is intended to be just for code-sharing and not called explicitly, I think for clarity it should be prefixed with an underscore, like _rapids-download-from-s3: https://github.com/rapidsai/gha-tools/blob/main/tools/_rapids-download-from-s3

[vyasr]

I'm supportive of consolidating more of the shared logic into one place like this, if you want to spend the time on it! Happy to review and help test.

If I hadn't already written this I wouldn't bother with the work, but now that I've come this far it seems a shame to waste it. It shouldn't take more than a few minutes to propagate the changes

If rapids-get-pr-artifact is intended to be just for code-sharing and not called explicitly, I think for clarity it should be prefixed with an underscore, like _rapids-download-from-s3: https://github.com/rapidsai/gha-tools/blob/main/tools/_rapids-download-from-s3

Sure I can do that. In the long run maybe it would make more sense to not have separate tools at all, but that's a minor cleanup task that we could do later.

[vyasr]

Done.

[jameslamb]

Just one minor suggestion, do what you want with it, otherwise this looks good to me!