Skip to content

Commit

Permalink
MAINT: Remove explicit legion dependency (and small fix based on review)
Browse files Browse the repository at this point in the history
Signed-off-by: Sebastian Berg <[email protected]>
  • Loading branch information
seberg committed Jan 20, 2025
1 parent dd1570a commit e1a1dd3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
6 changes: 0 additions & 6 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,6 @@ include(cmake/Modules/ConfigureCUDA.cmake) # set other CUDA compilation flags
# ##################################################################################################
# * dependencies ----------------------------------------------------------------------------------

rapids_find_package(
legate REQUIRED Legion LegionRuntime
BUILD_EXPORT_SET LegateDataframe-exports
INSTALL_EXPORT_SET LegateDataframe-exports
)

# add third party dependencies using CPM
rapids_cpm_init()

Expand Down
4 changes: 2 additions & 2 deletions cpp/src/sort.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ std::unique_ptr<cudf::column> get_split_ind(GPUTaskContext& ctx,
bool include_start)
{
auto nvalues_per_split = nvalues / nsplits;
auto nvalues_left = nvalues - nvalues_per_split * ctx.nranks;
auto nvalues_left = nvalues - nvalues_per_split * nvalues;
if (nvalues_per_split == 0) {
nsplits = nvalues_left; // Only return non-empty splits
}
Expand All @@ -81,7 +81,7 @@ std::unique_ptr<cudf::column> get_split_ind(GPUTaskContext& ctx,

#if DEBUG_SPLITS
std::ostringstream splits_points_oss;
splits_points_oss << "Split points @" << ctx.rank << ": ";
splits_points_oss << "Split points @" << nvalues << ": ";
for (auto point : split_values) {
splits_points_oss << point << ", ";
}
Expand Down

0 comments on commit e1a1dd3

Please sign in to comment.