Use rapids-metadata #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapids-metadata was created so that we wouldn't have to cut a new pre-commit-hooks release every time the structure of RAPIDS changes. Use rapids-metadata and get rid of the baked-in list of packages.
|
Note that this is currently expected to fail because |
jameslamb
requested changes
Jun 13, 2024
There was a problem hiding this comment.
I left some small suggestions on the code changes and a much larger one on the design for how updates work.
It'd be fine with me to just change the rapids-metadata dependency to a floor (no ceiling) and continue the design discussion about updates somewhere else. Up to you.
jameslamb
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapids-metadata was created so that we wouldn't have to cut a new pre-commit-hooks release every time the structure of RAPIDS changes. Use rapids-metadata and get rid of the baked-in list of packages.