Fix broken link to python doc #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowener
added
bug
cjnolet
reviewed
Jan 10, 2025
docs/source/sphinxext/github_link.py
Outdated
| fn = os.path.abspath(os.path.join("..", "python", fn)) | ||
| if fn.endswith(".pyx"): | ||
| sp_path = next(x for x in sys.path if re.match(".*site-packages$", x)) | ||
| fn = fn.replace("/opt/conda/conda-bld/work/python/cuvs", sp_path) |
There was a problem hiding this comment.
I think we need to make sure this builds for developers and not just by CI, right? Won't this break developers trying to build the docs locally?
cjnolet
approved these changes
Jan 16, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the same change as rapidsai/cuml#6202 to fix Python links to source code