Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GCC 13 in CUDA 12 conda builds. #2539

Open
wants to merge 4 commits into
base: branch-25.02
Choose a base branch
from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 13, 2025

Description

conda-forge is using GCC 13 for CUDA 12 builds. This PR updates CUDA 12 conda builds to use GCC 13, for alignment.

These PRs should be merged in a specific order, see rapidsai/build-planning#129 for details.

Copy link

copy-pr-bot bot commented Jan 13, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 13, 2025
@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 13, 2025
@bdice bdice self-assigned this Jan 13, 2025
@bdice bdice marked this pull request as ready for review January 13, 2025 19:37
@bdice bdice requested review from a team as code owners January 13, 2025 19:37
@bdice bdice requested a review from msarahan January 13, 2025 19:37
@jameslamb jameslamb requested review from jameslamb and removed request for msarahan January 13, 2025 20:01
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the packaging changes, assuming the fix for this build issue will be small and/or reviewed by C++ codeowners:

/opt/conda/conda-bld/work/cpp/test/label/label.cu: In member function 'virtual void raft::label::MakeMonotonicTest_Result_Test::TestBody()':
/opt/conda/conda-bld/work/cpp/test/label/label.cu:62:8: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
   62 |   delete data_h;
      |        ^~~~~~

(build link)

@bdice bdice requested a review from a team as a code owner January 13, 2025 20:19
cpp/test/label/label.cu Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

See this compilation failure on CI:

/opt/conda/conda-bld/work/cpp/include/raft/util/integer_utils.hpp:30:1: note: 'uint64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   29 | #include <stdexcept>
  +++ |+#include <cstdint>
   30 | #include <type_traits>

Submitted PR: #2540

Though please feel free to cherry-pick it here if that is helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - DO NOT MERGE Hold off on merging; see PR for details CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants