-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GCC 13 in CUDA 12 conda builds. #2539
base: branch-25.02
Are you sure you want to change the base?
Use GCC 13 in CUDA 12 conda builds. #2539
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the packaging changes, assuming the fix for this build issue will be small and/or reviewed by C++ codeowners:
/opt/conda/conda-bld/work/cpp/test/label/label.cu: In member function 'virtual void raft::label::MakeMonotonicTest_Result_Test::TestBody()':
/opt/conda/conda-bld/work/cpp/test/label/label.cu:62:8: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
62 | delete data_h;
| ^~~~~~
See this compilation failure on CI: /opt/conda/conda-bld/work/cpp/include/raft/util/integer_utils.hpp:30:1: note: 'uint64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
29 | #include <stdexcept>
+++ |+#include <cstdint>
30 | #include <type_traits> Submitted PR: #2540 Though please feel free to cherry-pick it here if that is helpful |
Description
conda-forge is using GCC 13 for CUDA 12 builds. This PR updates CUDA 12 conda builds to use GCC 13, for alignment.
These PRs should be merged in a specific order, see rapidsai/build-planning#129 for details.