Normalize whitespace #2547
Merged
Normalize whitespace #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
cjnolet
approved these changes
Jan 23, 2025
vyasr
approved these changes
Jan 24, 2025
|
@bdice unfortunately I think various upstream PRs merged while this was waiting for review. You'll probably find it easiest to revert the PR applying the hook, merge latest, then rerun the hook after. |
|
The merge conflict required no input -- it's just that GitHub's web interface doesn't know how to resolve renaming conflicts from #2546. This should be good to go, I'll trigger a merge. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies
pre-commithooks to normalize whitespace (trimming trailing whitespace and enforcing consistent end-of-file newlines).These rules are already applied to most other RAPIDS repos, so this PR aligns with the norm in RAPIDS.