Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove setup.cfg, use pyproject.toml #736

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

jameslamb
Copy link
Member

Description

This repo doesn't have a Python package or use setuptools, but it has a setup.cfg... to hold configuration for tools like codespell.

This proposes removing that and using a pyproject.toml to store that configuration, matching the conventions used across most of the rest of RAPIDS.

It also updates pre-commit configurations to use the latest version of rapids-dependency-file-generator (v1.17.0).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 23, 2024
@jameslamb jameslamb changed the title WIP: remove setup.cfg, use pyproject.toml remove setup.cfg, use pyproject.toml Dec 23, 2024
@jameslamb jameslamb marked this pull request as ready for review December 23, 2024 22:23
@jameslamb jameslamb requested review from a team as code owners December 23, 2024 22:23
@jameslamb jameslamb requested review from KyleFromNVIDIA and removed request for a team December 23, 2024 22:23
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need some pre-commit fixes for this repo. I realized in rapidsai/rmm#1769 that we didn't have codespell set up correctly for RMM.

I'll see if I can push a change and then approve this.

@bdice
Copy link
Contributor

bdice commented Dec 24, 2024

I applied the fix and it caught an issue with the config. I think the skip files needed to be wrapped in quotes or something. Also we don't need to ignore .github -- we aren't ignoring that in rmm (though we are in cudf...), but there are no typos, so I think it's fine to keep it included in the checks.

This should be good to go now.

@jameslamb
Copy link
Member Author

Ah great, thank you for fixing that! I didn't realize codespell didn't look for pyproject.toml by default.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 840accd into rapidsai:branch-25.02 Dec 24, 2024
15 checks passed
@jameslamb jameslamb deleted the no-setup-cfg branch December 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants