Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build_type to workflow inputs #1811

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

gforsyth
Copy link
Contributor

@gforsyth gforsyth commented Feb 3, 2025

Description

xref rapidsai/build-planning#147

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@gforsyth gforsyth requested a review from a team as a code owner February 3, 2025 20:08
@gforsyth gforsyth requested a review from bdice February 3, 2025 20:08
@gforsyth gforsyth added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 3, 2025
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Let's merge this and try to manually run test.yaml from the branch build that is created when this PR is merged: https://github.com/rapidsai/rmm/actions/workflows/test.yaml

@gforsyth
Copy link
Contributor Author

gforsyth commented Feb 3, 2025

Hmm, it looks like some of those jobs are waiting for runners that I don't think exist on NVKS

edit: nm, just a longish queue (I think)

@gforsyth
Copy link
Contributor Author

gforsyth commented Feb 3, 2025

/merge

@rapids-bot rapids-bot bot merged commit fe66a24 into rapidsai:branch-25.04 Feb 3, 2025
64 checks passed
@gforsyth gforsyth deleted the branch-test-workflow branch February 3, 2025 22:37
@gforsyth
Copy link
Contributor Author

gforsyth commented Feb 3, 2025

Manual run triggered here:

https://github.com/rapidsai/rmm/actions/runs/13124487384

rmm_manual_test_workflow

I cancelled the run, though, since the inputs still show the run-type as "nightly" despite the input field. I'll have to poke at this some more

@bdice
Copy link
Contributor

bdice commented Feb 3, 2025

@gforsyth Oops. I forgot to check that you used the input. :)

https://github.com/gforsyth/rmm/blob/cfee8fb3d25b0d3382983b037d71846104daa48e/.github/workflows/test.yaml#L24

For all the workflows here, we need to use build_type: ${{ inputs.build_type }}.

@bdice bdice mentioned this pull request Feb 3, 2025
3 tasks
@bdice
Copy link
Contributor

bdice commented Feb 3, 2025

A fix is in #1812. I requested an admin-merge on that PR because it's blocked. We created a catch-22 by introducing a failure on branch-25.04, because we now must have a successful run of the test workflow on branch-25.04 to unblock normal merges. We aren't running nightly CI on branch-25.04 yet, still on branch-25.02 for nightly CI.

raydouglass pushed a commit that referenced this pull request Feb 4, 2025
Fixes `build_type` input not being used in `test` workflows. See
#1811 (comment).
@gforsyth
Copy link
Contributor Author

gforsyth commented Feb 4, 2025

Thanks for fixing that up @bdice !

@gforsyth
Copy link
Contributor Author

gforsyth commented Feb 4, 2025

Ok, well, now it's failing because we're pulling from the nvks-runners shared-workflows branch and not the 25.04 branch -- I think I'll hold off on more of this until things have stabilized after 25.02.

https://github.com/rapidsai/rmm/actions/runs/13136963528/job/36654535543

@gforsyth
Copy link
Contributor Author

gforsyth commented Feb 4, 2025

ahh, i bet I need to poke this:

   TEST_MATRIX=$(yq -n 'env(MATRICES) | .[strenv(BUILD_TYPE)]')
  export TEST_MATRIX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants