-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build_type
to workflow inputs
#1811
Add build_type
to workflow inputs
#1811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Let's merge this and try to manually run test.yaml
from the branch build that is created when this PR is merged: https://github.com/rapidsai/rmm/actions/workflows/test.yaml
Hmm, it looks like some of those jobs are waiting for runners that I don't think exist on NVKS edit: nm, just a longish queue (I think) |
/merge |
Manual run triggered here: https://github.com/rapidsai/rmm/actions/runs/13124487384 I cancelled the run, though, since the inputs still show the run-type as "nightly" despite the input field. I'll have to poke at this some more |
@gforsyth Oops. I forgot to check that you used the input. :) For all the workflows here, we need to use |
A fix is in #1812. I requested an admin-merge on that PR because it's blocked. We created a catch-22 by introducing a failure on |
Fixes `build_type` input not being used in `test` workflows. See #1811 (comment).
Thanks for fixing that up @bdice ! |
Ok, well, now it's failing because we're pulling from the https://github.com/rapidsai/rmm/actions/runs/13136963528/job/36654535543 |
ahh, i bet I need to poke this:
|
Description
xref rapidsai/build-planning#147
Checklist