remove system-installed UCX headers in wheel build environment #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#57.
Follow-up to #226.
Proposes the following changes for wheel builds:
libuc*
)Notes for Reviewers
Before applying similar changes to
ucx-py
, I noticed it being compiled with the system-installed headers but then linking against the libraries provided by thelibucx
wheels: rapidsai/ucx-py#1041 (comment)This change should reduce the risk of that happening.
How I tested this
Poked around the filesystem that
build_wheel.sh
runs in by pulling one of our standard wheel-building container images used in CI.