Hdr options changes #590
Merged
Hdr options changes #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the option values and behaviour the same, but now unconditionally set the sensor HDR control to 0 when starting, and only set to 1 if we are using an IMX708 sensor. This annoyingly involves opening the camera manager multiple times in certain configurations. Signed-off-by: Naushir Patuck <[email protected]>
|
It all seems fair enough to me... if quite a lot of effort for something that you feel shouldn't have been needed in the first place! |
The camera manager may be initialised multiple times depending on the current and wanted state of the sensor HDR control. Avoid this by having the camera manager accessable from the Options class and only re-initialising it if the state of the sensor HDR control has changed. Do this carefully enough, and there ought to be no change in behaviour perceived by a application or the user. Signed-off-by: Naushir Patuck <[email protected]>
| app_->initCameraManager(); | ||
|
|
||
| // Unconditionally disable libcamera logging for a bit. | ||
| libcamera::logSetTarget(libcamera::LoggingTargetNone); |
There was a problem hiding this comment.
Does this suppress only infos and debugs, or does it remove errors and warnings?
We might want to keep the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.