piolib: examples: Overhaul dpi_interlace, now named dpi_csync #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
reviewed
Dec 11, 2024
piolib/examples/dpi_csync.c
Outdated
| @@ -0,0 +1,358 @@ | |||
| /** | |||
| * Copyright (c) 2020 Raspberry Pi (Trading) Ltd. | |||
There was a problem hiding this comment.
Is the copyright date correct or copy pasta?
There was a problem hiding this comment.
Whoops. It was copied from "dpi_interlace.c". It looks like several of the examples have it.
Should be 2024 of course - I'll correct it.
The program now generates Composite Sync for both progressive and interlaced DPI. Equalizing pulses have been removed, to generalize. Signed-off-by: Nick Hollinghurst <[email protected]>
njhollinghurst
force-pushed
the
dpi_csync
branch
from
eaf2703 to
c512ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves some PIO bits and pieces from raspberrypi/linux#6529 that didn't go into the kernel.
The progressive case is potentially useful and instructive (how to generate CSync from HSync and VSync).
For interlaced modes things are a bit more obscure; it depends on DPI having modified VSync in a certain way (as noted in a comment).