Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to auto-language if highlighting fails #96

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adamwulf
Copy link

I ran into a case where the highlight would return undefined from javascript. it seems due to an unsupported language name. Instead, this case is retried with automatic highlighting, which does return a valid result.

Copy link
Owner

@raspu raspu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the CSS changes are out of scope for this MR.

NachoSoto added a commit to NachoSoto/Highlightr that referenced this pull request Jul 22, 2024
Same as raspu#96 but without the CSS changes.
Some change in 2.2.0 made this issue resurface.
NachoSoto added a commit to NachoSoto/Highlightr that referenced this pull request Jul 22, 2024
Same as raspu#96 but without the CSS changes.
Some change in 2.2.0 made this issue resurface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants