-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Prepare 0.2.0 #94
base: master
Are you sure you want to change the base?
Conversation
Ok it looks like there is generated_jit in here which needs to be removed for it to work on Python3.10 and newer versions of numba |
One has to use this pattern, which unfortunately involves more typing: https://github.com/ratt-ru/codex-africanus/blob/42e8433dab744992ab73f8babce75d52b505e1bf/africanus/rime/phase.py#L11-L21 |
'threadpoolctl >= 1.0.0', | ||
'dask-ms == 0.2.6', | ||
'zarr >= 2.3.1' | ||
'dask[array] >= 2021.2.0, <=2024.3.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dask-ms imports this directly, this could probably be dropped.
setup.py
Outdated
'zarr >= 2.3.1' | ||
'dask[array] >= 2021.2.0, <=2024.3.1', | ||
'donfig >= 0.4.0, <0.8.2', | ||
'numpy >= 1.14.0, <= 1.22.0', # breakage in newer numpy + numerical errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dask[array] imports this directly, this could probably be dropped (unless numerical errors are a concern)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently testing while I migrate to python 3.10. I want to pin the requirements down on maximum versions. I will be ditching setuptools shortly though
Starting this as a draft to move the package to Python 3.10 and add a few wanted features.