Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update benchmark with real tests #51

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Update benchmark with real tests #51

merged 1 commit into from
Dec 22, 2022

Conversation

wilsonwang371
Copy link
Contributor

@wilsonwang371 wilsonwang371 commented Nov 2, 2022 •
edited
Loading

No description provided.

@wilsonwang371 wilsonwang371 force-pushed the wilson/update-benchmark branch 4 times, most recently from 9e11283 to e53e179 Compare November 2, 2022 18:02
@wilsonwang371
Copy link
Contributor Author

@pabloem hi pablo, is it normal to have the benchmark test running for almost 30 minutes? The test is the one you mentioned in #21

image

@wilsonwang371
Copy link
Contributor Author

cc @iasoon @pdames

@pabloem
Copy link
Collaborator

pabloem commented Nov 2, 2022

that does not sound normal, but maybe it is given our current implementation? if it's running to completion then it should be fine?

@wilsonwang371
Copy link
Contributor Author

that does not sound normal, but maybe it is given our current implementation? if it's running to completion then it should be fine?

let me check if i can have more log printed and see what has happened.

@wilsonwang371 wilsonwang371 force-pushed the wilson/update-benchmark branch 2 times, most recently from 900e2ab to 486ba8c Compare November 30, 2022 07:51
@wilsonwang371 wilsonwang371 changed the title [WIP] Update benchmark with real tests Update benchmark with real tests Nov 30, 2022
@pabloem
Copy link
Collaborator

pabloem commented Dec 13, 2022

this looks good to me. Thanks!

@jjyao - I think we can set up a github pages website for this repository so that we can see the benchmark results. WDYT?

pabloem
pabloem reviewed Dec 14, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@wilsonwang371 wilsonwang371 force-pushed the wilson/update-benchmark branch from 0ea7f4e to 1169e37 Compare December 21, 2022 05:32
@wilsonwang371 wilsonwang371 force-pushed the wilson/update-benchmark branch from 1169e37 to 02fd7fd Compare December 21, 2022 05:54
@wilsonwang371
Copy link
Contributor Author

@pabloem Hi Pablo, please take a look at the new patch. Thanks

@pabloem
Copy link
Collaborator

pabloem commented Dec 22, 2022

lgtm!

@pabloem pabloem merged commit ecc9dba into ray-project:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloem pabloem pabloem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilsonwang371 @pabloem