[build][cmake] Set PLATFORM to Web by default when configuring web builds with emcmake #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the CMake web build by setting the
PLATFORMtoWebby default when configuring builds usingemcmake cmake.This solution is the same as 9821725 wanted to achieve, but for it to work the value must be set before
enum_option(PLATFORM ...)is called, that's why it didn't work before.My only doubt is if it's best to just set the default value like I did, or if it makes sense to force PLATFORM to Web and only call
enum_option(PLATFORM ...)in theelse()branch, since Emscripten cannot build raylib with any other value of PLATFORM set.