Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StubGen] Intruduce length:return #71

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

sebaszm
Copy link
Contributor

@sebaszm sebaszm commented Jan 9, 2024

Adds @length:return to be used when the length of a returned buffer is carried on the return value.
This allows for optimizations:

  • not sending the entire possible buffer on the inbound message (i.e. from maxlength), but just what was really filled in,
  • omitting sending of the result on the inbound message (as the length is already sent within the buffer).

This is used in ICryptography.

Additionally fixed a bug that mixed length with maxlength fixing previously broken IPerformance::Exchange(). Additional optimizations are applicable now as above.

Also fixes emitting of some tautology code, making compiler happy.

@sebaszm sebaszm marked this pull request as draft January 9, 2024 15:48
@sebaszm sebaszm force-pushed the development/stubgen-length-return branch 2 times, most recently from dfcda67 to d240866 Compare January 9, 2024 16:11
@sebaszm sebaszm force-pushed the development/stubgen-length-return branch from d240866 to 77bd667 Compare January 10, 2024 08:43
@sebaszm sebaszm marked this pull request as ready for review January 10, 2024 08:44
@sebaszm sebaszm merged commit c1dc18c into master Jan 11, 2024
19 checks passed
@sebaszm sebaszm deleted the development/stubgen-length-return branch January 11, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants