Feat: Native SDK unit tests part 1 #325

AdityaKasar · 2024-09-23T18:46:06Z

Unit tests with google test framework, dependency updates

Changes pulled in from PR 315

CLAassistant · 2024-09-23T18:46:12Z

All committers have signed the CLA.

github-actions · 2024-09-23T18:52:32Z

Core SDK - MFOS standalone sanity report:
Passes - 178 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/28741814022/artifacts/1967917095
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/11000481742

src/sdks/core/src/cpp/sdk/cpptest/unit/accessibilityTest.cpp

kschrief · 2024-09-23T20:16:11Z

src/sdks/core/src/cpp/sdk/cpptest/unit/advertisingTest.cpp

+
+    Firebolt::Advertising::AdvertisingId actualValues= Firebolt::IFireboltAccessor::Instance().AdvertisingInterface().advertisingId(options, &error);
+
+    ASSERT_EQ(error, Firebolt::Error::None) << "Error occurred during advertisingId call";


Can we print the error we get if we get one?

Can this logging be done in all tests?

Modified all tests with appropriate logging

kschrief · 2024-09-23T20:18:45Z

src/sdks/core/src/cpp/sdk/cpptest/unit/capabilitiesTest.cpp

+}
+
+
+TEST_F(CapabilitiesTest, TestCapabilitiesinfo) {


Can we have some more clarity through comments on what's being tested here?

this still needs to be addressed. but somehow became outdate. will keep this open until being addressed

kschrief · 2024-09-23T20:20:51Z

src/sdks/core/src/cpp/sdk/cpptest/unit/deviceTest.cpp

+    EXPECT_EQ(actualValue.type, expectedValues.type);
+}
+
+TEST_F(DeviceTest, DeviceScreenResolution)


Is there a difference between this test and the one at line 243?

good spot! there was a correction in test name, the correct name for the other test is TEST_F(DeviceTest, VideoResolution). Now corrected.

github-actions · 2024-09-24T05:23:03Z

Core SDK - MFOS standalone sanity report:
Passes - 178 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/28759660012/artifacts/1969783867
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/11007474285

github-actions · 2024-09-24T05:25:59Z

Core SDK - MFOS standalone sanity report:
Passes - 178 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/28759733015/artifacts/1969789541
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/11007502738

github-actions · 2024-09-24T23:18:27Z

Core SDK - MFOS standalone sanity report:
Passes - 178 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/28804000431/artifacts/1974295838
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/11023318309

rdkcmf-jenkins · 2024-09-25T10:47:20Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/firebolt-apis/325/rdkcentral/firebolt-apis
Commit: eafe257

Report detail: gist'

rdkcmf-jenkins · 2024-09-25T10:49:51Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/firebolt-apis/325/rdkcentral/firebolt-apis
Commit: 24e2020

Report detail: gist'

github-actions · 2024-09-25T10:50:33Z

Core SDK - MFOS standalone sanity report:
Passes - 178 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/28824448821/artifacts/1976344137
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/11031420916

github-actions · 2024-09-25T10:54:56Z

Core SDK - MFOS standalone sanity report:
Passes - 178 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/28824629425/artifacts/1976360397
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/11031488213

rdkcmf-jenkins · 2024-09-25T11:30:08Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: OK
Commit: 24e2020
'

parag-pv · 2024-10-02T19:52:57Z

Moved to #328
@AdityaKasar please close this PR

AdityaKasar requested review from kschrief and parag-pv September 23, 2024 18:54

kschrief requested changes Sep 23, 2024

View reviewed changes

AdityaKasar force-pushed the feature/core-sdk-unit-test branch 2 times, most recently from 63b0c64 to d34b44d Compare September 24, 2024 05:19

parag-pv changed the title ~~Core SDK Unit tests~~ Feat: Native SDK unit tests part 1 Sep 24, 2024

parag-pv mentioned this pull request Sep 24, 2024

Feat: Native SDK unit tests part 1 #315

Closed

AdityaKasar force-pushed the feature/core-sdk-unit-test branch from b3de5d7 to eafe257 Compare September 25, 2024 10:44

AdityaKasar added 11 commits September 25, 2024 16:18

test(core): Unit test setup

622d05a

test(core): Accessibility module unit tests

1a139ca

test(core): Account module unit tests

415ff9b

test(core): Advertising module unit tests

2b448ef

test(core): Authentication module unit tests

a4e6e04

test(core): Capabilities module unit tests

0bb732c

test(core): Device module unit tests

1cec81d

test(core): Lifecycle module unit tests

87b4622

test(core): Metrics module unit tests

9d8e743

test(core): Parameters module unit tests

9fb9be6

test(core): Profile module unit tests

24e2020

AdityaKasar force-pushed the feature/core-sdk-unit-test branch from eafe257 to 24e2020 Compare September 25, 2024 10:48

AdityaKasar requested a review from ksentak September 25, 2024 14:21

parag-pv mentioned this pull request Sep 30, 2024

Feat: Native SDK unit tests part 1 (Updated) #328

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Native SDK unit tests part 1 #325

Feat: Native SDK unit tests part 1 #325

AdityaKasar commented Sep 23, 2024 •

edited by parag-pv

Loading

CLAassistant commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024

kschrief Sep 23, 2024

AdityaKasar Sep 25, 2024

kschrief Sep 23, 2024

AdityaKasar Sep 25, 2024

kschrief Sep 23, 2024

AdityaKasar Sep 25, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

rdkcmf-jenkins commented Sep 25, 2024

rdkcmf-jenkins commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

rdkcmf-jenkins commented Sep 25, 2024

parag-pv commented Oct 2, 2024


		Firebolt::Advertising::AdvertisingId actualValues= Firebolt::IFireboltAccessor::Instance().AdvertisingInterface().advertisingId(options, &error);

		ASSERT_EQ(error, Firebolt::Error::None) << "Error occurred during advertisingId call";

		}


		TEST_F(CapabilitiesTest, TestCapabilitiesinfo) {

Feat: Native SDK unit tests part 1 #325

Are you sure you want to change the base?

Feat: Native SDK unit tests part 1 #325

Conversation

AdityaKasar commented Sep 23, 2024 • edited by parag-pv Loading

CLAassistant commented Sep 23, 2024 • edited Loading

github-actions bot commented Sep 23, 2024

kschrief Sep 23, 2024

Choose a reason for hiding this comment

AdityaKasar Sep 25, 2024

Choose a reason for hiding this comment

kschrief Sep 23, 2024

Choose a reason for hiding this comment

AdityaKasar Sep 25, 2024

Choose a reason for hiding this comment

kschrief Sep 23, 2024

Choose a reason for hiding this comment

AdityaKasar Sep 25, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

rdkcmf-jenkins commented Sep 25, 2024

rdkcmf-jenkins commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

rdkcmf-jenkins commented Sep 25, 2024

parag-pv commented Oct 2, 2024

AdityaKasar commented Sep 23, 2024 •

edited by parag-pv

Loading

CLAassistant commented Sep 23, 2024 •

edited

Loading