Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRECERT-2042] Suspended performance. Initial commit #115

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

parag-pv
Copy link
Contributor

  • Performance metrics validation for lifecycle suspended
  • Support for custom validation
  • Misc bug fixes

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ppavit606 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/lifecycle.js
  412:19  error  Replace `">>>·setAppState·SUSPENDED"` with `'>>>·setAppState·SUSPENDED'`                  prettier/prettier
  413:19  error  Replace `">>>·setAppState·currentAppState:·"` with `'>>>·setAppState·currentAppState:·'`  prettier/prettier
  417:23  error  Replace `">>>·current·state·not·inactive"` with `'>>>·current·state·not·inactive'`        prettier/prettier
  422:11  error  Insert `;`                                                                                prettier/prettier
  431:8   error  Delete `⏎·····`                                                                           prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/main.js
  489:15  error  'message' is never reassigned. Use 'const' instead                                                                                        prefer-const
  489:64  error  Replace `fcsValidationObjectData,·apiOrEventObject` with `⏎············fcsValidationObjectData,⏎············apiOrEventObject⏎··········`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  325:7   error  'expected' is never reassigned. Use 'const' instead                                               prefer-const
  325:18  error  Replace `"LIFECYCLE_"` with `'LIFECYCLE_'`                                                        prettier/prettier
  326:15  error  Replace `">>>·expected:·"` with `'>>>·expected:·'`                                                prettier/prettier
  331:9   error  Delete `····`                                                                                     prettier/prettier
  332:1   error  Replace `············` with `········`                                                            prettier/prettier
  339:29  error  Replace `">>>·CASE·CUSTOM"` with `'>>>·CASE·CUSTOM'`                                              prettier/prettier
  343:29  error  Replace `"Unsupported·lifecycle·validation·type"` with `'Unsupported·lifecycle·validation·type'`  prettier/prettier
  347:11  error  Insert `;`                                                                                        prettier/prettier
  349:7   error  Insert `;`                                                                                        prettier/prettier
  350:5   error  Replace `⏎··` with `;`                                                                            prettier/prettier

✖ 17 problems (17 errors, 0 warnings)
  17 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants