gh #11 Pre and Post condition update for CEC HAL APIs #12
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilbhas
reviewed
Aug 29, 2024
There was a problem hiding this comment.
HI @krishna-1809 ,
Can you clarify the doubts I have in the changes ?
include/hdmi_cec_driver.h
Outdated
| @@ -159,7 +159,7 @@ HDMI_CEC_STATUS HdmiCecOpen(int *handle); | |||
| * @retval HDMI_CEC_IO_NOT_OPENED - Module is not initialised | |||
| * @retval HDMI_CEC_IO_INVALID_HANDLE - An invalid handle argument has been passed | |||
| * | |||
| * @pre HdmiCecOpen() must be called before calling this API. | |||
| * @pre HdmiCecOpen(), HdmiCecRemoveLogicalAddress() must be called before calling this API. | |||
There was a problem hiding this comment.
HdmiCecRemoveLogicAddresse is required only if HdmiCecAddLogicAddress() is called , right ?
There was a problem hiding this comment.
no need to add pre condition of HdmiCecRemoveLogicAddresse () for close
check this https://github.com/rdkcentral/rdk-halif-hdmi_cec/blob/main/include/hdmi_cec_driver.h#L152
srinivasgtl
added
enhancement
Removed : @pre - HdmiCecAddLogicalAddress in Get Physical Address Physical address will be acquired first and then only Logical Address will be updated
hari22yuva
reviewed
Jan 8, 2025
krishna-1809
dismissed stale reviews from srinivasgtl and akhilbhas
via
5816606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Logical Address - @pre condition for CEC HAL APIs after HdmiCecOpen()
Remove Logical Address - @pre condition for CEC HAL APIs for HdmiCecClose()