feat(type): value supports generic definition #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 98.26% 98.27% +0.01%
==========================================
Files 2 2
Lines 115 116 +1
Branches 27 27
==========================================
+ Hits 113 114 +1
Misses 2 2 ☔ View full report in Codecov by Sentry. |
20 tasks
MadCcc
reviewed
Dec 8, 2023
Comment on lines
+87
to
+89
| "resolutions": { | ||
| "types-ramda": "0.29.4" | ||
| }, |
There was a problem hiding this comment.
貌似跑 tsc 会挂，但是今天看 181 pr 又是好的，估计是 tsconfig include有点问题吧
MadCcc
reviewed
Dec 8, 2023
src/index.tsx
Outdated
| @@ -65,7 +68,7 @@ function normalizeOptions(options: SegmentedOptions): SegmentedLabeledOption[] { | |||
| }); | |||
| } | |||
|
|
|||
| const InternalSegmentedOption: React.FC<{ | |||
| interface _InternalSegmentedOptionProps { | |||
There was a problem hiding this comment.
Suggested change
| interface _InternalSegmentedOptionProps { | |
| interface InternalSegmentedOptionProps { |
MadCcc
reviewed
Dec 8, 2023
src/index.tsx
Outdated
| /** | ||
| * Generic parameter `Value` is supported since 2.3.0 | ||
| */ | ||
| export interface SegmentedProps<Value extends SegmentedValue = SegmentedValue> | ||
| extends Omit<React.HTMLProps<HTMLDivElement>, 'onChange'> { | ||
| options: SegmentedOptions; |
|
Duplicate of #181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.