fix(Overlay): fix target type for react 19 refs #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
approved these changes
Jan 13, 2025
|
How do you want to do the release here? one more minor with this and my changes or just go major and drop old react? |
I'm thinking your changes already warrant a major, so we should branch, add my fix in and we can release from that branch for the patch. Will do one last release on RB before switching over the build to mimic here. |
|
I'll take care of that patch release later tonight |
kyletsang
added a commit
that referenced
this pull request
Jan 16, 2025
|
Hey @jquense, can you add branch protection for the "v1" branch? I don't have permissions to do so |
|
bumped your permissions up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in react 19 where initial values are mandatory for refs and null was not allowed
Closes react-bootstrap/react-bootstrap#6883