Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(0227-server-module-conventions): typo boundary #234

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(0227-server-module-conventions): typo boundary #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf7a2a5
fix(0227-server-module-conventions): typo boundary
AndersDJohnson Nov 4, 2022
9e404ed
fix(0227-server-module-conventions): more typos
AndersDJohnson Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion text/0227-server-module-conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ The nice thing about this convention is that it works outside of Server Componen

# TypeScript Convention

Types between the Server and Client boundary mostly just work because they behave the same as if there was no boundaray. One limitation is that if those types includes a non-serializable type - according to the React Server Components specification, you get an error.
Types between the Server and Client boundary mostly just work because they behave the same as if there was no boundary. One limitation is that if those types include a non-serializable type, according to the React Server Components specification, you get an error.

The correct way to model this is to model Client References for exports at the boundaries and then have the callsite of JSX accept a Client Reference as a component and enforce the serialization at the callsite. This ensures that you can still pass client references from server to client in other forms than JSX. In fact, this is how Flow already implements it and it could be implemented in TypeScript too. However, this requires a bit more involved type checking from the TypeScript side.

Expand Down