Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Serialize: Materials #462

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Python Serialize: Materials #462

merged 6 commits into from
Nov 29, 2023

Conversation

bzaczynski
Copy link
Contributor

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

@bzaczynski bzaczynski changed the title Python Serialize: (Materials Python Serialize: Materials Nov 13, 2023
@bzaczynski bzaczynski requested a review from gahjelle November 13, 2023 15:53
Copy link
Contributor

@gahjelle gahjelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a minor language update. Otherwise, this looks good to me!

@KateFinegan KateFinegan merged commit 25a5652 into master Nov 29, 2023
1 check passed
@KateFinegan KateFinegan deleted the python-serialize branch November 29, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants