Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample code for the article on dictionaries #614

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Sample code for the article on dictionaries #614

merged 5 commits into from
Dec 2, 2024

Conversation

lpozo
Copy link
Contributor

@lpozo lpozo commented Nov 20, 2024

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

bzaczynski
bzaczynski approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@bzaczynski bzaczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brendaweles brendaweles merged commit ca7b0bb into master Dec 2, 2024
1 check passed
@brendaweles brendaweles deleted the python-dicts branch December 2, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendaweles brendaweles brendaweles approved these changes

@bzaczynski bzaczynski bzaczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpozo @bzaczynski @brendaweles