chore(deps): Upgrade pytz for python 3.10 compat #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran it locally, it already is. |
|
ah, it was a python 3.10 change. let me correct |
ditsuke
changed the title
ditsuke
force-pushed
the
chore/update-dep-pytz
branch
from
9c53bf9 to
8c5468c
Compare
|
rebased, @realslimshanky can we please keep them stacked? To make reviewing easier I think my latest PR can be tested. |
Updates pinned version of "requests" for compat with the required urllib3 version.
ditsuke
force-pushed
the
chore/update-dep-pytz
branch
from
8c5468c to
93b600a
Compare
Upgrades pytz to the latest version for python 3 support
Merged
|
@ditsuke in case we're planning to use stacked PR, you'll have to change merge branch to ditsuke:chore/update-dep-pytz. But that won't work since the branch is not in this repo but it's in the fork. So we can mark this PR blocked. Let #26 merge and then rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Upgrades the
pytzdependency to the latest version.This is a Stacked PR stacked atop #26.
Please review in tandem and merge the PRs, without squashing or rebasing, in sequence.
Why
The previously pinned version used an API (
collections.Mapping) moved tocollections.abcin python3.10.