This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Make compatible with GraphQL PPX 1.0 beta #117
Draft
jfrolich
wants to merge
14
commits into
reasonml-community:master
Choose a base branch
from
jfrolich:apollo3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d204995
migrate to apollo 3
jfrolich be25c3b
remove dependency on reason-apollo
jfrolich 832b9ae
Raw t
jfrolich 3dc63a0
Merge branch 'master' of https://github.com/Astrocoders/reason-apollo…
jfrolich 55c801b
improvements
jfrolich 4ebe66d
add new types to make compatible with serialize functionality
jfrolich 6e659bb
Update to new graphql-ppx API
jfrolich 05bb4da
Fix type
jfrolich 8ec92ac
Add more functionality
jfrolich da84066
Add no required variables functionality
jfrolich 4ee0931
Compatibility upgrade and more typesafe API
jfrolich a599cd8
add ssr
jfrolich 01db25b
Use new makeVariables function
jfrolich f8259d8
reformat
jfrolich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,4 @@ | ||
[@bs.module "@apollo/client"] [@react.component] | ||
external make: | ||
( | ||
~client: ApolloClient.generatedApolloClient('raw_t), | ||
~children: React.element | ||
) => | ||
React.element = | ||
(~client: ApolloClient.t, ~children: React.element) => React.element = | ||
"ApolloProvider"; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be amazing if this would be moved to another package so reason-apollo and reason-apollo-hooks could share the same ApolloClient definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better to have a single package, because the hooks are now also part of the same
@apollo/client
package.