Merge pull request #233 from reaviz/syang/dialog-drawer-close-aria

add aria-labels for close buttons on dialog and drawer
reaviz · Jun 20, 2024 · 22c44f1 · 22c44f1
2 parents 91375f3 + bc72998
commit 22c44f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/layers/Dialog/DialogHeader.tsx b/src/layers/Dialog/DialogHeader.tsx
@@ -65,6 +65,7 @@ export const DialogHeader: FC<DialogHeaderProps> = ({
           type="button"
           className={theme.header.closeButton}
           onClick={onClose}
+          aria-label="Close"
         >
           ✕
         </button>

diff --git a/src/layers/Drawer/DrawerHeader.tsx b/src/layers/Drawer/DrawerHeader.tsx
@@ -53,6 +53,7 @@ export const DrawerHeader: FC<DrawerHeaderProps> = ({
           type="button"
           className={theme.closeButton.base}
           onClick={onClose}
+          aria-label="Close"
         >
           ✕
         </button>