-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactive Popover hover state #100
Conversation
This is to add the ability to interact with the content of a tooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So Tooltips are not supposed to be interactive - if you need a interactive 'tooltip' thats what the popover is for. I'd rather have you style that similar than extend this.
Ah ok, so style a popover as in activate it on hover? I'll look into doing that instead |
Ok now this functionality only works on Popover's when the trigger is |
if ( | ||
isPopover && | ||
(trigger === 'hover' || | ||
(Array.isArray(trigger) && trigger.includes('hover'))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor optimization - you could make this a variable like isPopoverInteraction
and also reuse it for onMouseLeave
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Popovers disappear when you hover over them/try to interact with their content while using a
hover
trigger. There's no options to enable this kinda behaviorWhat is the new behavior?
Popover's stay visible while they're hovered when using
hover
triggerDoes this PR introduce a breaking change?
Other information
Screen.Recording.2024-02-12.at.9.16.29.AM.mov