Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recreate notify method on notifications list update #102

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

evgenoid
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Every time when notifications list is updated - notify method updates as well, what is involve unnecessary render triggers

What is the new behavior?

Get notifications list from setNotifications callback to avoid notifications dependency for notify callback

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@evgenoid evgenoid requested a review from amcdnl February 14, 2024 12:08
@evgenoid evgenoid self-assigned this Feb 14, 2024
@evgenoid evgenoid merged commit c97fc12 into master Feb 14, 2024
1 check passed
@evgenoid evgenoid deleted the bugfix/notifications branch February 14, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants