Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dateFormat prop #172

Merged
merged 2 commits into from
May 11, 2024
Merged

Remove unused dateFormat prop #172

merged 2 commits into from
May 11, 2024

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented May 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

Does this PR introduce a breaking change?

[x] Yes (technically I guess?)
[ ] No

Other information

This props not getting used anywhere, and there's no date's being displayed in the calendar to use it on

date in this story's being displayed outside Calendar
Screenshot 2024-05-09 at 10 41 46 AM

@ghsteff ghsteff requested a review from amcdnl May 9, 2024 14:43
Copy link

netlify bot commented May 9, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit ba5e5f5
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/663cf59a8f2d1d00087acee4
😎 Deploy Preview https://deploy-preview-172--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit ac3d512 into master May 11, 2024
5 checks passed
@amcdnl amcdnl deleted the Remove-unused-calendar-prop branch May 11, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants