Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to style states of disabled toggle #196

Closed
wants to merge 2 commits into from

Conversation

steppy452
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
Disabled state for Toggle only had one class

What is the new behavior?

Disabled state for Toggle can now be separated into base (toggle is off) and checked states

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Also updated the Toggle disabled story to include both states of disabled Toggles

Copy link

netlify bot commented May 17, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 45c2607
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66478f71158f6000088d84ba
😎 Deploy Preview https://deploy-preview-196--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets figure out best naming standard. Also lets document that in the docs around best practices.

@steppy452
Copy link
Contributor Author

doesn't seem like this is needed anymore

@steppy452 steppy452 closed this May 17, 2024
@steppy452 steppy452 deleted the syang/toggle-updates branch May 17, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants