Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace/remove inexistant text-xs classes #201

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented May 17, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

text-xs doesn't exist in the tw config so these don't do anything

Screen.Recording.2024-05-17.at.1.49.26.PM.mov

text-xs doesn't exist in the tw config so these don't do anything
@ghsteff ghsteff requested a review from amcdnl May 17, 2024 17:54
Copy link

netlify bot commented May 17, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 5059324
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/664799d3d8a5b80008b33bcd
😎 Deploy Preview https://deploy-preview-201--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -37,7 +37,7 @@ const baseTheme: ListTheme = {
disableGutters: 'pl-0 pr-0',
dense: {
base: 'p-1',
content: 'text-xs',
content: '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this small instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's small from the text-sm on the non-dense content. Now dense and not dense lists are the same font size but different padding

@amcdnl amcdnl merged commit 98a1a85 into master May 19, 2024
5 checks passed
@amcdnl amcdnl deleted the Remove-inexistant-text-xs branch May 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants