Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification dialog #203

Closed
wants to merge 3 commits into from
Closed

Notification dialog #203

wants to merge 3 commits into from

Conversation

evgenoid
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: GOOD-223

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No
Screenshot 2024-05-20 at 13 49 19 Screenshot 2024-05-20 at 13 49 26 Screenshot 2024-05-20 at 13 49 32 Screenshot 2024-05-20 at 13 49 39 Screenshot 2024-05-20 at 13 49 45 Screenshot 2024-05-20 at 13 49 57 Screenshot 2024-05-20 at 13 50 07

@evgenoid evgenoid self-assigned this May 20, 2024
Copy link

netlify bot commented May 20, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 648b195
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/664b2b8114eca5000818eaf8
😎 Deploy Preview https://deploy-preview-203--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a notification component - we should just update those styles not make a new component.

@amcdnl amcdnl closed this May 20, 2024
@evgenoid evgenoid reopened this May 20, 2024
@evgenoid
Copy link
Contributor Author

We already have a notification component - we should just update those styles not make a new component.

Yes, but it has a little bit different goal. We use it for informing use on one-way direction. In this case we need some feedback from user like submit or decline action. And this notification should stay on screen until user close it

@evgenoid
Copy link
Contributor Author

Let's add Notification variants instead

@evgenoid evgenoid closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants