Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stepper #205

Merged
merged 6 commits into from
May 21, 2024
Merged

Stepper #205

merged 6 commits into from
May 21, 2024

Conversation

evgenoid
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Issue Number: GOOD-225

Does this PR introduce a breaking change?

[ ] Yes
[x] No
Screenshot 2024-05-21 at 10 24 05 Screenshot 2024-05-21 at 10 24 11 Screenshot 2024-05-21 at 10 24 17 Screenshot 2024-05-21 at 10 24 24

Other information

@evgenoid evgenoid requested review from amcdnl, steppy452 and ghsteff May 21, 2024 07:30
@evgenoid evgenoid self-assigned this May 21, 2024
@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited
Loading

✅ Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 81a9f6d
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/664c5c071f6a900008137894
😎 Deploy Preview https://deploy-preview-205--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amcdnl
amcdnl reviewed May 21, 2024
View reviewed changes
src/layout/Stepper/Step.tsx
}

export const Step: FC<StepProps> = ({ children, className }) => (
<div className={className}>{children}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs a role?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean this one https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably listitem but I'm not sure

@amcdnl amcdnl merged commit ad29aec into master May 21, 2024
5 checks passed
@amcdnl amcdnl deleted the stepper branch May 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcdnl amcdnl amcdnl approved these changes

@steppy452 steppy452 Awaiting requested review from steppy452

@ghsteff ghsteff Awaiting requested review from ghsteff

Assignees

@evgenoid evgenoid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgenoid @amcdnl