-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Callout component #225
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for reablocks-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add docs once we release
an alternative to making a separate component for each variant could be to map the variants to their default icons and also give the ability to override that with the
and then render the icon like
|
I've made solution which you described (but with switch/case for icon) first time, but Austin ask to extract it on several component to make it cleaner, that why I updated it to have several components |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #50
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Variants
Custom Icon
Custom Text